Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 3 years ago

Basic CSS and using image overlay

Dan Bennett•60
@inkfromblood
A solution to the NFT preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


By far the most difficult part was creating the image overlay. There were so many different ways to approach this and many seemed needlessly complicated, or that they required more code than seemed reasonable. I worked towards finding this simplest solution. I was able to achieve close to the desired result.

HOWEVER, the one part I cannot figure out is why my overlay is is JUST slightly larger in height than than the image itself. I currently have both the .overlay height and width set to 100% - as I believe thats what the code should be in the cleanest stay. But if I changed the height to 98% then it fits fine and looks the best. But I wanted to leave it as is in the inaccurate state, because I can't figure out why its doing that and changing it to that 98% feels like I'm just covering up a mistake that I don't understand.

One thing I learned, was that rather than just going into code to BUILD UP, I really should be BREAKDING DOWN the design first and doing some sort of wireframing or outlining first. This will help me to develop better organization and better hierarchies for when placing and labeling divs within divs.

Really looking forward to feedback on this, because this one STARTED better than the QR code, but quickly took me quite a while to get to what I wanted.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Roberto Yukio Miyamoto Arita•320
    @RyukioMiyamoto
    Posted about 3 years ago

    Excellent work Dan! I had the same issue regarding the img height, while I solved it differently, there's a simple solution that is to add display: block to it, erasing the white space. I'm not 100% sure about why but I think the reason it works is because it makes the element take up all available space in its "line". Anyway, good job!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub