Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 3 years ago

Basic CSS with media queries and flexbox

Atul kumar•200
@AtulKumar0001
A solution to the 3-column preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I would appreciate any suggestions you might have.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • gmqrk247•90
    @gmqrk247
    Posted almost 3 years ago

    Hey!

    Great work! One little hint, if you put a transparent border on the button on it's normal state, you can avoid the growing and shrinking with the hover effect. just like this:

    .btn{border:2px solid transparent}
    
    Marked as helpful
  • Laharl•1,000
    @UrbanskiDev
    Posted almost 3 years ago

    Hello Atul kumar !

    Congratulation for finishing this project

    1. In your html file, I recommend you to modify your <div class="container"> by a <section>, a div tag has no meaning in html while section does have one !

    I give you a link about section tag, and html semantics in general to learn more about it :

    • W3Schools section tag
    • W3Schools semantic html
    1. In your css file, you can define variable to make it easier to maintain, like color definition :
    :root{
    --var-name:hsl(31, 77%, 52%);
    }
    
    .card1{
    background-color:var(--var-name);
    }
    

    I give a link to learn more about them :

    • MDN CSS Variable

    I hope it helps you, keep learning and happy coding !

    Marked as helpful
  • Lucas 👾•104,160
    @correlucas
    Posted almost 3 years ago

    👾Hello Atul kumar, congratulations for your first solution!👋 Welcome to the Frontend Mentor Coding Community!

    Your solution seems fine, you did a really good job wrapping the content for these 3 cards. Something you can improve here is to use a single class to manage the content that is mostly the same for the 3 cards (paddings, colors, margins and etc) and another class to manage the characteristics that are different (colors and icon), this way you'll have more control over then and if you need to change something you modify only one class. Add a margin of around margin: 20px to avoid the card touching the screen edges while it scales down.

    ✌️ I hope this helps you and happy coding!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub