Basic HTML and CSS

Community feedback

• 

  Travolgi 🍕•31,300

  @denielden

  Posted over 2 years ago

  Hello Jai, You have done a good work! 😁

  Some little tips to improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • remove container div and add background: hsl(212, 45%, 89%) to the body
  • also you can use article tag instead of a simple div to the container card for improve the Accessibility
  • remove all margin from .content-container class because with flex they are superfluous
  • use flexbox to the body to center the card. Read here -> best flex guide
  • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
  • instead of using px use relative units of measurement like rem -> read here

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  10

  Marked as helpful
• 

  Lord Robins•610

  @ZenitsuAg

  Posted over 2 years ago

  Hello Jal, you code is really amazing, neat and also readable. Here are some tips to help you improve your code.

  • It's better to wrap the entire code within a main tag.
  • It's also better to use max-width and max-height properties instead of width and height for responsive purposes.

  Happy Coding

  00

  Marked as helpful