Skip to content
Submitted 2 months ago

Basic HTML and CSS

Brian Cisneros•20
@cisneros1
A solution to the QR code component challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

What specific areas of your project would you like help with?

How can i improve the way my css is written? In terms of shortening and or better ways to write the css.

Code

Please log in to post a comment

Log in

Community feedback

  • Marzia Jalili•8,390
    @MarziaJalili

    Hats off to your embarking on this amazing journey! 🥳🥳🥳

    ✅ Just a tiny tip; avoid using px for font-size as it happens to cause some issues for the users. I suggest you look into rem units instead for a more responsive design.

    Keep up the grind!

    😎😎😎

  • hidayahmsabah•160
    @hidayahmsabah

    Hi Brian, your solution and the challenge's expected solution is pretty much spot on.

    Some suggestions for your CSS, usually font-family properties are defined in body element instead of child element. This way you don't have to specify it inside each child element. I'm not sure if font-style: normal is necessary, since the default value is already normal. But if you need to apply it to your entire site, you can also define it in the body element.

    This was a pretty simple challenge, so there' not much I can comment on your code but all in all, it was written pretty well.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord