Basic NFT card using HTML and CSS

Community feedback

• 

  Jayme•50

  @jaymew88

  Posted about 3 years ago

  Hey!

  Great job on your first challenge! The project looks great.

  A couple of things that were already mentioned in your feedback, that I noticed as well, deleting any unnecessary comments and using CSS variables for colors and fonts. On additional thing I would like to add is the Document should have one main HTML element, contain the component in <main>.

  Can't wait to see more!

  00

  Marked as helpful
• 

  Eric Salvi•1,350

  @ericsalvi

  Posted about 3 years ago

  Hey!

  I love the solution you did for the hover effect on the image and revealing the eye icon. When I did this, I struggled a bit but yours is a bit more simplified. Great job with your first submission.

  A few things to keep an eye out for would be after you submit your solution, check out the report that gets generated to check for errors and accessibility issues.

  View Report Here

  A tool you could use in Chrome Dev Tools before you submit is AxeDevTools (extension download).

  Another thing I would suggest doing is to remove any unneeded comments from your HTML and CSS and make sure to remove any CSS that is not needed (ie. .attribution).

  One thing you could try to start using is CSS Variables for things such as colors. It makes it so much easier to code, I found.

  Great job again, and I look forward to seeing more submissions from you in the future.

  00

  Marked as helpful