Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Basic profile card CSS+HTML

@Elridge2

Desktop design screenshot for the Profile card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Im not very good with css. I tried the challenge and got it to kinda look like it, but I was not sure how to clip the background circles so the page wont scroll so far, and for some reason when I open the site on mobile the scaling is all messed up. Does anybody know how to go about fixing these problems?

Community feedback

@pikapikamart

Posted

Hey, good work on this one. I think @sirriah already pointed out key points that you should suggest working or refactoring on.

My additions would be that,

  1. there seems to be a scrollbar appearing, it is caused by the bottom circle since it overlaps the body's width right. To fix this, you could add overflow: hidden in your body tag, so that everything that overlaps the body, will be cut off.

  2. Add a media breakpoint for the mobile size state, since now your card have fixed width right, so when a user scales down, your layout will not. Adding a width: 100% to your .card selector will be awesome, but keep in mind, put them in media breakpoint before doing so, okay.

Overall, your work is fine, and if need more help, feel free to drop it here^

0

@Elridge2

Posted

@pikamart Thank you so much for the feedback very helpful I will study some more!

0
Tereza 605

@sirriah

Posted

Hello, I saw your code :) Here are some suggestions:

  • For the two big circles try to use pseudo elements ::before and ::after - tutorial here. These circles are only decoration and it is not the part of the content => move them into css. Try to use img tag only for content images - here is it the profile picture.
  • the part about "followers, likes, photos" is not well done. You have to think about screen reader - what it will read? 80k 803k 1.4k Followers Likes Photos um? Related data should be join together into the columns. Try to watch some tutorial about flexbox.
  • Do not use names like "img1". Add names which are related to the content. You can use BEM naming.
  • Try to keep formatting of the code. If you use VS Code (I recommend), try the right-click-mouse and there should be something like "formatting".

Have a nice day! Happy coding :)

0

@Elridge2

Posted

@sirriah Thank you for the feedback I will look into those things I still have a lot to learn!!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord