Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 8 months ago

BEM, Flexbox, Accesibility

accessibility, bem
Emerson Lima•200
@poissonfou
A solution to the Bookmark landing page challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I am proud of making the website more accessible by making it possible to interact with the accordion and the tabs section through the keyboard. I'm also happy to have implemented a simple and intuitive solution to create the accordion section.

What challenges did you encounter, and how did you overcome them?

I've had issues with the layout jumping when I added hover effects to elements like buttons, because it would add a border to those elements when they previously didn't have them. I solved it by adding a transparent border to those element in their default style.

What specific areas of your project would you like help with?

I still struggle to properly name my classes. I've tried to implement a BEM architecture but ended up breaking it a few time because I thought the class names were becoming to verbose. I would appreciate if someone could point out how I could've better name my classes and implemented BEM.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Marc Francis•730
    @marcfranciss
    Posted 8 months ago

    Impressive solution to this challenge! 💯

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit 1st-party linked stylesheets, and styles within <style> tags.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub