
Solution retrospective
This is my second handson challenge. For the 1st challenge I needed some reference to complete, for this challenge I tried it without any reference.
What challenges did you encounter, and how did you overcome them?fonts were provided as .ttf files. But I have imported the google fonts. Learning on how to use ttf files.
What specific areas of your project would you like help with?All suggestions are welcomed. Thank you in advance.
Please log in to post a comment
Log in with GitHubCommunity feedback
- @andreaselmi
Hi there! Great work so far, you're doing well! 😊
Just a few quick suggestions (if I may) to help you improve:
Use rem instead of px: This helps make your website more accessible, especially when users adjust their browser’s font size. It's a good habit to start using rem units early on!
Make class names more descriptive: Class names like text1 or text2 make the code harder to read and understand. Try using more meaningful names like card__title or card__description. It helps keep your CSS organized and easier to maintain. You can check out this naming convention: https://getbem.com
Watch out for spacing and border values: For example, in this code:
#article { width: 100%; border-radius: 13px; margin-bottom: 15px; }
You've used different values that don’t follow design values. A good rule of thumb, by the way, is to use multiples of 4 (like 12px, 16px, 20px…) for consistent spacing and a cleaner design.
Avoid using IDs in CSS: It's generally better to use classes instead of IDs when styling elements. Classes are more flexible and follow best practices, especially when your project grows.
Keep going 💪 Let me know if you ever want more help or feedback :)
Marked as helpful
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord