Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Blog Preview card

P
Anthony Young• 30

@A-Young-Git

Desktop design screenshot for the Blog preview card coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

took slaythedragon.io's css course and now i was able to slice my workflow time in half and understand what im doing every step of the way.

What challenges did you encounter, and how did you overcome them?

getting border-radius to round the entire image container. I needed to use the overflow:hidden property.

What specific areas of your project would you like help with?

open to any suggestions or feedback

Community feedback

P

@Islandstone89

Posted

Hi Anthony, good job!

Here are some suggestions :)

HTML:

  • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Wrap the card in a <main>.

  • Replace <span> with <p>.

  • Consider using the <time> element for the date:<p>Published <time datetime="2023-12-21">21 Dec 2023</time></p>.

  • As this is a blog card, the heading needs a link inside.

  • The heading should be a <h2>, as the card would likely wouldn't be the only component on a page.

CSS:

  • Add around 1rem of padding on the body, so the card doesn't touch the edges on small screens.

  • Add width: fit-content on "Learning", so it doesn't stretch across the card.

  • Except for the author image, remove all widths and heights in px.

  • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

  • It is common practice to add display: block and max-width: 100% on images. The max-width prevents it from flowing out of its container.

  • On .author__section, remove justify-content: space-between, and add gap: 1rem.

Marked as helpful

0

P
Anthony Young• 30

@A-Young-Git

Posted

Thank you! Super helpful feedback. Will make the changes shortly. Appreciate it. @Islandstone89

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord