@Islandstone89
Posted
HTML:
-
Use classes instead of IDs.
-
Profile image needs a short, descriptive alt text: "Headshot of Gary Hooper".
-
Footer text must be wrapped in
<p>
.
CSS:
-
Including a CSS Reset at the top is good practice.
-
Remove the
html
selector. -
font: weight 500;
should befont-weight: 500
. -
On the
body
, changeheight
tomin-height
- this way, the content will not get cut off if it grows beneath the viewport. Remove the width, as the body is 100% wide by default. -
Do not use
%
formargin
,padding
orgap
. -
font-size
must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead. -
Paragraphs have a default value of
font-weight: 400
, so there is no need to declare it. -
Remove the width on
.container
. -
Add a
max-width
of around20rem
on the card, to prevent it from getting too wide on larger screens.