Solution retrospective
This project was really cool. I think the most challenging part was getting the svg to scale with the parent container. I didn't seem to get that part right at all, resulting in a smaller image height than the actual. I would appreciate some feedback on this. Besides that, working from the figma design file proved very insightful and helpful.
What challenges did you encounter, and how did you overcome them?Scaling svg to fill parent container.
What specific areas of your project would you like help with?Scaling svg to fill parent container.
Please log in to post a comment
Log in with GitHubCommunity feedback
- P@Stroudy
Great work on this! You should be proud of how far you've come. Here are a few observations that might help you improve further…
-
For future project, You could downloading and host your own fonts using
@font-faceimproves website performance by reducing external requests, provides more control over font usage, ensures consistency across browsers, enhances offline availability, and avoids potential issues if third-party font services become unavailable. -
You have a few
font-sizeinpxI would change them toremfor consistency with the rest of the code, -
I think you can benefit from using a naming convention like BEM (Block, Element, Modifier) is beneficial because it makes your CSS more organized, readable, and easier to maintain. BEM helps you clearly understand the purpose of each class, avoid naming conflicts, and create reusable components, leading to a more scalable codebase. For more details BEM,
Great job taking the time to learn! Your efforts are paying off, and I hope these insights guide you to even more success. Keep pushing forward, and remember, you’ve got this! Enjoy your coding adventures! 💪
-
- P@nikxe
c
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord