Melvin Aguilar 🧑🏻💻• 61,480
@MelvinAguilar
Posted
Hello there 👋. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
- The
alt
attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information.
-
For a photo of a person, use their name as the alt text
If you want to learn more about the
alt
attribute, you can read this article. 📘.
- Setting the width of the component with a percentage or a viewport unit will behave strangely on mobile devices or large screens. You should use a max-width of
380px
to make sure that the component will have a maximum width of380px
on any device, also remove thewidth
property with a percentage value.
- Use
min-height: 100vh
instead ofheight
. Setting the height to 100vh may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation.
I hope you find it useful! 😄 Above all, the solution you submitted is great!
Happy coding!
1