Blog Preview Card using flex

Community feedback

• 

  P

  Daniel 🛸•44,790

  @danielmrz-dev

  Posted over 1 year ago

  Hello @karldreta!

  Your solution looks great!

  I have a couple of suggestions for improvement:

  • First: In order to make your HTML code more semantic, use <h1> for the main title instead of <h3>. Unlike what most people think, it's not just about the size and weight of the text.

  📌 The <h1> to <h6> tags are used to define HTML headings.

  📌 <h1> defines the most important heading.

  📌 <h6> defines the least important heading.

  📌 Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

  • Second: Still about semantic HTML, use <main> to wrap the main content instead of <div>.

  All these tag changes may have little or no visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, great job!

  10

  Marked as helpful
• 

  Melvin Aguilar 🧑🏻‍💻•61,020

  @MelvinAguilar

  Posted over 1 year ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  Background 🌆:

  • You should not recreate the background, you used the image desktop-preview.jpg to create your solution, but that image is for decoration and is a nice way to present the challenge, for example, you can use it in your github README.

    You must use the images desktop-design.jpg and mobile-design.jpg to create your solution.

  HTML 🏷️:

  • Wrap the page's whole main content in the <main> tag.

  • Always avoid skipping heading levels; Starting with <h1> and working your way down the heading levels (<h2>, <h3>, etc.) helps ensure that your document has a clear and consistent hierarchy. Source 📘

  • For specificity reasons you should work with classes instead of ids because they are more reusable. You can use ids to work with JavaScript, but you should use classes to style your elements. You can read more about this here 📘.

  I hope you find it useful! 😄

  Happy coding!

  10

  Marked as helpful