@Islandstone89
Posted
Hey, well done. Here are some suggestions:
HTML:
-
Every webpage needs a
<main>
that wraps all of the content, except for<header>
andfooter>
. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Change.container
to a<main>
. -
Wrap the date in a
<time>
element:<p>Published <time datetime="2023-12-21">21 Dec 2023</time></p>
. -
The heading would have a link as this is a blog card.
-
.attribution
should be a<footer>
, and you should use<p>
for the text inside. It needs to be moved outside of the<main>
.
CSS:
-
Including a CSS Reset at the top is good practice.
-
Add around
1rem
ofpadding
on thebody
, so the card doesn't touch the edges on small screens. -
Move
font-family
,font-size
andfont-weight
from*
tobody
. -
Move all the properties on
.container
tobody
. -
Remove the width on
.card
and.category
. -
Add a
max-width
of around25rem
on the card, to prevent it from getting too wide on larger screens. -
font-size
must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead. -
Add
display: inline-block
on.category
, this prevents it from taking up the full width.
Marked as helpful