@nicm42
Posted
In your app.js you're looking at window resize to show and hide the menu button, but you can just do that in your CSS - so your hamburger menu will have display none on desktop but not in mobile.
You're also making life hard for yourself by having styles for mobile and styles for desktop because you're then writing some of the same things twice. What you can do is to write all your styles for mobile or desktop, then use media queries to overwrite anything that changes for desktop/mobile. You can even write a mixin for that! If you haven't discovered Kevin Powell on YouTube yet, then he has some good Sass content
@iSamBa
Posted
@nicm42 Thank you so much for this constructive feedback, I discovered scss during this attempt, so I don't have a lot of knowledge about it. I will definetly go check Kevin Powell channel (Thx for the suggestion). This was my first attempt, I'm not satisfied with the overall structure, I need to remake it. Thanks again @nicm42