Solution retrospective
I am new to web development, and I really need your constructive feedback.
Please log in to post a comment
Log in with GitHubCommunity feedback
- @nicm42
In your app.js you're looking at window resize to show and hide the menu button, but you can just do that in your CSS - so your hamburger menu will have display none on desktop but not in mobile.
You're also making life hard for yourself by having styles for mobile and styles for desktop because you're then writing some of the same things twice. What you can do is to write all your styles for mobile or desktop, then use media queries to overwrite anything that changes for desktop/mobile. You can even write a mixin for that! If you haven't discovered Kevin Powell on YouTube yet, then he has some good Sass content
- @codeswithroh
There are a lot of problems that you need to address. For starters, the empty-space after your footer should be removed. Then, your texts are spilling over. So, you also need to take care of those.
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord