Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Blogr

Sam 20

@iSamBa

Desktop design screenshot for the Blogr landing page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


I am new to web development, and I really need your constructive feedback.

Community feedback

Nic 595

@nicm42

Posted

In your app.js you're looking at window resize to show and hide the menu button, but you can just do that in your CSS - so your hamburger menu will have display none on desktop but not in mobile.

You're also making life hard for yourself by having styles for mobile and styles for desktop because you're then writing some of the same things twice. What you can do is to write all your styles for mobile or desktop, then use media queries to overwrite anything that changes for desktop/mobile. You can even write a mixin for that! If you haven't discovered Kevin Powell on YouTube yet, then he has some good Sass content

1

Sam 20

@iSamBa

Posted

@nicm42 Thank you so much for this constructive feedback, I discovered scss during this attempt, so I don't have a lot of knowledge about it. I will definetly go check Kevin Powell channel (Thx for the suggestion). This was my first attempt, I'm not satisfied with the overall structure, I need to remake it. Thanks again @nicm42

0

@codeswithroh

Posted

There are a lot of problems that you need to address. For starters, the empty-space after your footer should be removed. Then, your texts are spilling over. So, you also need to take care of those.

0

Sam 20

@iSamBa

Posted

@codeswithroh Thank you for your feedback, I removed the space after the footer. Regarding the texts can you please make a screenshot, so that i can fix that as well ?

0
Sam 20

@iSamBa

Posted

@codeswithroh I opened the solution using Firefox, and I could see the text problem you are talking about, but with Chrome everything looks good. I need to figure that out.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord