@zineb-Bou
Posted
Hi there, your solution looks good, is nicely responsive and I love the animation on the header, here are some suggestions concerning accessibility.
- The pattern images are only for decoration, we don’t need the screen readers to read their source path, therefore we have to hide them from assistive technologies using
aria-hidden=” true”
- The close button on the navigation menu is a button, so use the right HTML semantic element which is a
<button>
instead of a<div>
.
Good luck
Marked as helpful
@DanteBenicio
Posted
@zineb-Bou Thanks for the tip, I'm starting to study these accessibility issues and that's why there are still things I don't know yet, but thanks, I'll do that 👍