Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Blogr Page (Semantic HTML5, CSS, Native JS)

@iceofice

Desktop design screenshot for the Blogr landing page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


I would like to get feedback on my overall CSS and js practices.

Community feedback

Eles 1,300

@eleswastaken

Posted

Hi! Always set background color. You see, in my browser I set default background color to be white-pinkish and on pages with no set bg it is very noticeable. The other thing is about paddings. When you try to look at the page from different devices(phone, large screen, tablet) your paddings are one, similar on all of them. So use different paddings for different device screen sizes. Font seemed on my laptop way too big(especially header-nav).

Marked as helpful

1

@iceofice

Posted

@eleswastaken Hi! I never knew we can set a default background on browser. Thanks for letting me know. May I know do you set a default font-size also, I tried using em and rem for this challenge, maybe that's why. For the padding maybe I'll have more media queries in the css. Thank you for the feedback!

0
Eles 1,300

@eleswastaken

Posted

@iceofice Yes, you do set an overall font-size at your top tag(*, body or something).

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord