Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

blogr-landing-page

Hamada• 240

@Elbassel511

Desktop design screenshot for the Blogr landing page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Feedback is welcome

Community feedback

Anosha Ahmed• 9,340

@anoshaahmed

Posted

hey good job on this challenge! your report above shows a few issues though:

  • wrap everything in your body in <main> OR use semantic tags! if you're using div right after body, then give them a role=""; however, it's a little frowned upon to use role right after body, so try to stick with semantic tags instead. you can read more about landmarks here

  • <section> and <article> usually need a heading; if you don't need a heading, use some other element such as <div>

here is a list i made of accessibility issues & best practices

hope this helps :))

Marked as helpful

0

Hamada• 240

@Elbassel511

Posted

@anoshaahmed Thanks for your feedback

1
Rio Cantre• 9,710

@RioCantre

Posted

Hello there! Great job with this project. Looking at your solution, you did well in implementing the design. I would suggest the following for you, in case you want to considered it...

  • Adjust the padding of the buttons into 0.8em
  • Remove padding-inline: clamp(2em,5vw,9.5em); instead use padding: 2rem 5rem; and adjust top: 2rem; inside the nav rule set
  • Add margin-right: 1rem; in the .login-btn
  • Remove margin-top: 4rem; on img
  • For best practice wrap the list items with the closing tag like this...
<ul class="dropdown-menu-m flow " id="menu-m-0" aria-labelledby="products-btn-m">
              <li> Overview</li>
              <li> Pricing</li>
              <li> Marketplace</li>
              <li> Features</li>
              <li> Integrations</li>
 </ul>
  • Remove the inline style style="padding-inline:2em ; and add it on the CSS file
  • Clean the Whitespaces in the code

Hope this helps and Keep up the good work!

Marked as helpful

0

Hamada• 240

@Elbassel511

Posted

@RioCantre Thanks for your feedback, it's very helpful , i will work through these points and update my solution.

1
Naveen Gumaste• 10,480

@NaveenGumaste

Posted

Hay ! Good Job you made it look nearly perfect to the preview

These below mentioned tricks will help you remove any Accessibility Issues

-> Add Main tag after body like it should be your container

-> For 1st heading or h1 tag, use header tag and then inside the header put your h1 or h2 etc

-> But use header tag only once in main heading element.

-> This is all i understood in your errors so not much help to you as i am a newbie😊

Keep up the good work!

Marked as helpful

0

Hamada• 240

@Elbassel511

Posted

@Crazimonk Thanks for your feedback, i will work through these points

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord