Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 4 years ago

Blogr-Landing-Page | Reponsive | HTML,CSS,JS

Tejas•265
@Tejas-117
A solution to the Blogr landing page challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Any feedback is appreciated. Thank you. Just don't mind my weird class names. 😁

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • tediko•6,700
    @tediko
    Posted about 4 years ago

    Hello, Tejas! 👋

    Good job on this challenge! Your solution looks quite well and responds good. What I can suggest is:

    • Since your .logo, .editor-img, .laptop, .footer-logo images are decorative your alt text should be provided empty (alt="") so that they can be ignored by assistive technologies, such as screen readers.
    • Add :focus pseudo class to interactive elements like anchors, buttons etc. Use outline property to make your website more accessible to keyboard users. Focusable elements like anchor, buttons or inputs they have applied default :focus pseudo class with outline property. These default styles are subtle and hardly visible tho. Furthermore every browser has a slightly different default style for the outline, so you probably want to change the default style. Read more about why we should change focus styles.
    • Try to work on the class names, they are non-intuitive and hard to read in the code. Instead of .top-section, .second-section, .third-section use more specific ones like .hero, .about .features etc.

    Good luck with that, have fun coding! 💪

  • Nic•595
    @nicm42
    Posted about 4 years ago

    Looking at this, I'm disappointed your class names aren't weirder - I thought they were quite logical!

    But I'm finding your CSS a bit odd - you have some mobile specific bits, some desktop specific bits and some tablet specific bits. And some navbar links changes only for specific sizes. It's generally easier to design for one size (either small or big) and then work up or down. That way you don't need so many media queries, and you also don't have to have ones that include min and max, as the bottom one takes precedence.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit 1st-party linked stylesheets, and styles within <style> tags.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub