Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 3 years ago

Bookmark Landing Page developed with React.js

accessibility, react, webpack
dannxvc•180
@dannxvc
A solution to the Bookmark landing page challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hi, this is my first web site developed with React.js from scratch. I used useState and useEffect hooks to handle on click. I appreciate any feedback about my code. Thank you so much, I've learnt a lot by making this challenge.

Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • Joramt•20
    @Joramt
    Posted almost 3 years ago

    I just found frontendmentor and your submission, and congrats it's absolutely spot on ! Very good work, idk your level but this is coming from a consultant front end developer ( Jorel Amthor if you want to check me on LinkedIn )

    Things you could improve and or expand, from easiest to hardest : Write modern JS; look into arrow function, how to use typescript, how to compile typescript file into JS using webpack Use router to have different URLs; i know this is a SPA but you try adding different page. Instead of having everything on one, try using react router to have a /pricing /feature /contact dedicated pages :) Use Redux to maintain state to display what browser you support; instead of hardcoding each supported browser, you could define a Redux store containing a SupportedBrowsers list of Browser object, each made of { id: (unique Id to identify the browser ), displayName: ( name of the browser ), browserImg: ( IMG url of the browser) }. You could loop through that list to render a Browser component which will take the data above as a prop.

    Have fun, and once again, from a total neutral stranger, very, very, very good job !

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub