Bootstrap
Solution retrospective
This is my first project on Frontend Mentor. Could you please provide me some feedback on the work I have done. Tkank you.
Please log in to post a comment
Log in with GitHubCommunity feedback
- @pikapikamart
Hey, great work on your first challenge here in FEM. The layout in desktop is fine, though it is somehow pushed onto the top, the mobile state is good.
Some suggestions would be that:
-
In our markup, html, we usually does not use multiple h1. We tend to only use 1 h1 per page. On your case, you used multiple h1, you could just use other heading tags like h2 or h3, and just use h1 like a screen-reader only heading.
-
Adding an alt text to the images. The images are the 3 cars right, if the image is meaningful, add meaningful alt, if not, then just use
alt=""leaving it blank.
Well those only, good job on this and it is really nice^
-
- @MohamedBehhar
hey Yana, for your first challenge I think that you did a good job, otherwise, I see that you forget to give a border-radius for the card's parent, and also the background color didn't match the one on the design. For the mobile version, I think it's better to reduce the margin between elements ( h1, p , and img) to make the design more beautiful. At the end, I'll be happy if you took a look at one of my projects and give me some advice to make it even better.
- @soodaayush
Maybe fix the accessibility and HTML issues. Your font on the buttons does not look right compared to the design photo.
That's all I have to say.
Happy Coding!
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord