Bootstrap5

Community feedback

• 

  Travolgi 🍕•31,280

  @denielden

  Posted almost 3 years ago

  Hello Saynum, You have done a good work! 😁

  Some little tips to improve your code:

  • add header tag and wrap the navbar for improve the Accessibility
  • add main tag and wrap the main page content for improve the Accessibility
  • also you can use article tag instead of a simple div to the container of news for improve the Accessibility
  • you can use picture tag to change image by resolution -> read here

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  10

  Marked as helpful
• 

  Joshua Mo•130

  @joshua-mo-143

  Posted almost 3 years ago

  Hey there, this looks like a pretty good solution so far.

  I think going forward, trying out CSS Grid to align the website layout would be a good idea to try and focus on. The site looks perfectly fine on desktop, but on mobile/tablet layout the top left part of the page (especially the main article splash text/button) becomes misaligned with the black sidebar menu which is a bit of a shame.

  Otherwise it looks pretty good. Using article or section instead of div to help distinguish between articles/sections on the sitepage would help a lot with adding semantic HTML.

  10
• 

  suhayb jirde•1,110

  @suhaybjirde

  Posted almost 3 years ago

  well done i just did it with pure css

  00