Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 4 years ago

Build with HTML, SCSS and Vanilla JS.

Che Kin To•130
@chekinto
A solution to the Digital bank landing page challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hi guys, I think I went a bit too far with regards to folder structure on this project but hey hahaha. If possible would someone be able to feedback on how I could make the hero images responsive (and fix the z-index for mobile mock up images), as I found this was the most challenging part of the challenge.

I also wanted to know if there was better way to simplify my 'toggleMobileNav function) which is below: I tried using a classList.toggle but it caused problems when I was toggling the document.body.style for the overflow

toggleMobileNav = (e) => { if (!isOpen) { line.classList.add('active') overlay.classList.add('is-modalOpen') mobileNav.classList.add('is-mobileOpen') document.body.style.overflow = 'hidden' isOpen = true } else { line.classList.remove('active') overlay.classList.remove('is-modalOpen') mobileNav.classList.remove('is-mobileOpen') document.body.style.overflow = 'initial' isOpen = false } }

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Abhik•4,820
    @abhik-b
    Posted over 4 years ago

    Hello Che Kin To 👋

    Great job on this challenge , it is responsive and it looks great. I really liked the menu btn changing to a cross and reverting back animations 👌

    Just Some Opinions

    • How I would have approached hero section is :
    1. put the bg-intro to background-image of hero section and then position it with background-position
    2. give the section a grid or flex display and position the .container and another div
    3. and inside that div I would place a img with mockups image( later I can animate the img while page loads😅 )
    4. then position them according to the media-queries
    • How I would have approached mobile nav :
    1. I would not have created a different nav for mobile
    2. I would have hidden that nav for mobile screen, (like you do) but will give that different styles
    3. and then display it when the menu btn is clicked

    ** That's the way I would have approached , I hope this is useful to you **

    Overall Great Job 💯💯, Keep contributing these amazing solutions and Happy Coding 😇

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub