Rostyslav Nazarenko• 560
@rostyslav-nazarenko
Posted
Hi! Excellent solution! 🙂
- HTML (accessibility problems)
- wrap your code in
maintag or changediv class="card"tomain class="card" - change
div class="attribution"tofooter class="attribution" altshould describe an image or its function and be empty only if it is only decorative, read more about alternative text here. In this challengealtcan beQR code to frontendmentor.ioso you can show the image function in this case
- wrap your code in
- CSS
- it is not recommended to set
font-size: 62.5%;read about it here - use
min-height: 100vh;onbodyelement so that in case of overflow it will allow scrolling - change the background color to match to the design
- it is not recommended to set
Have a nice day👋!
Marked as helpful
1
Shiash• 100
@kloprop
Posted
@rostyslav-nazarenko Thanks for your feedbacks
I always forget to add tags like main and footer , thanks for the reminder
I see the point of using min-height but for the font size of 62.5%, I need time to digest and understand.
1
