Frontend Mentor | Calculator app || using css grid vanilla JS coding challenge solution

Solution retrospective

This is my first intermediate challenge. Really enjoyed doing this challenge.

There is a room for improvement, I should had used slider for theme switcher and calculator logic had become messy to cover all the logical error.

I think layout look nice.

Any feedback or comment would be appreciated on code or design.

Community feedback

Bazmul• 55

@MoBazmul

Posted almost 3 years ago

@soransh-singh, I love the design layout, it's perfect, though there are some bugs you need to fix, like you cannot do any operation on two decimal numbers and when you multiply a decimal number and an integer, the results returned is too big e.g., 0.2×3, the answer displayed is 0.600000000000001...nice work

soransh singh• 1,025

@soransh-singh

Posted almost 3 years ago

@bazmul Thanks for the feedback really appreciate ....yhaa i will try to resolve them ... the code is messy so I have to clean the code and make it more readable... and Also this error will occur if you multiply 1.6x3

soransh singh• 1,025

@soransh-singh

Posted almost 3 years ago

@bazmul hey... I have resolved all the known issues ... thanks again for the feedback.

Faris P• 2,810

@FarisPalayi

Posted almost 3 years ago

Hey, it looks fantastic. 👏. Good job! Layout is responding nicely.

I caught a bug 🐞, You can't do decimal point calculations, for example, you can't do this: 0.2 - 0.1. When you click the dot button, the dot doesn't show up on the calculator display.

I can see that it only took you 2-3 days to complete this challenge. So, I think you did an excellent job tackling this challenge!

soransh singh• 1,025

@soransh-singh

Posted almost 3 years ago

@FarisPalayi thankss ... I will try to resolve it... Also you cannot do multiplication/division of two negative number 😂😂😂

Faris P• 2,810

@FarisPalayi

Posted almost 3 years ago

@soransh-singh oh, right, division/multiplication becomes a subtraction, right? 😇. I was going to say addition doesn't work with that too. But -1+ -1 = -1-1, right? 😅

soransh singh• 1,025

@soransh-singh

Posted almost 3 years ago

@FarisPalayi yhaa ... alsoright now js code is so messsy that even i will not understand it after a week .... I think I should add different event listeners for "." And "-" sign to solve this issues and also to make code more readable (i should had paid attention to my algo classes 😂😂)

Faris P• 2,810

@FarisPalayi

Posted almost 3 years ago

@soransh-singh 😄😂

soransh singh• 1,025

@soransh-singh

Posted almost 3 years ago

@FarisPalayi hey... I resolved all the issues... thanks for the feedback

Faris P• 2,810

@FarisPalayi

Posted almost 3 years ago

@soransh-singh yep. Everything is working perfectly 👍. Well done !👏

soransh singh• 1,025

@soransh-singh

Posted almost 3 years ago

@FarisPalayi thanks ... also I am thinking of making it a PWA ... But don't know how to make one 😂😅

Faris P• 2,810

@FarisPalayi

Posted almost 3 years ago

@soransh-singh Yep, me too😀,

Web.dev has great resources on PWA - Progressive Web Apps. I'm currently learning about PWAs using their resources. I think it's really good. Give it a try if you can.

soransh singh• 1,025

@soransh-singh

Posted almost 3 years ago

@FarisPalayi I will try it ... Thanks

Calculator app || using css grid vanilla JS

Design comparison

Solution retrospective

Community feedback

Please log in to post a comment

Join our Discord community