Calculator app with React and hyoka

Community feedback

• 

  Elaine•11,360

  @elaineleung

  Posted almost 3 years ago

  Hi Ola, this was a well-built solution, and I think it's really a great thing that you built your own library to process the evaluation, and that you got to use it here. I tested it and found it to be very functional, and I can see in your screenshot that there should be some trig functions as well, but I'm not sure how to access that.

  In any case, for a calculator with a fairly basic design, using an expression evaluator might be a bit of an overkill. The design is meant for single-step operations, as can be seen by how limited the screen space is, and I think using trig functions or other similarly complex ones is still doable with a single-step operation calculator (I had one in my school days, so I know it's possible!). With an expression evaluator, it's probably better if the display is multi-line, like a graphing calculator. In any case, I still think your library was well built, as was this solution. I would be curious to see whether a very basic single-step calculator can still be made using this library, and I'm not sure whether you have built an expression evaluator calculator before, but if you haven't, maybe you can extend this challenge and give that a shot.

  By the way, be sure to fix the issues in your report! 🙂

  Great work here, Ola, really well done!

  01