Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Card Ping Soon Page (Css Flexbox ▪🍬▪ )

#accessibility#animation#bem#jss#sass/scss
Desktop design screenshot for the Ping single column coming soon page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello community, I have finished this project and I really like the design and I added a small animation for the social links, if you have some improvements for my code, or about the accessibility, you can tell me in the comments, really help me to improve. Thanks and Happy coding. 🍕

Community feedback

Tryt4n 940

@Tryt4n

Posted

Between width of 480px to around 700px on your social link icons narrow because you use width: 30% on .footer__social. Also for <form> element you could add some padding-inline because below 580px elements inside touch the edges and personally I would add text-wrap: nowrap; on your button because between 480-570px text is wrapping. For image you could change it so that it is always the same width as the form.

For accessibility:

  • text "soon" in your h1 could not be visible for assestive technologies. Instead of that you could wrap it in strong or b or just leave it as it is and add <span class="visually-hiden>soon</span>
  • label is empty. You could add span with visually-hiden class and some text like "email"
  • add aria-errormessage="some_id" to your input
  • to you warning text add this id and aria-live="assertive"
  • © symbol is the same as &copy ; but without space between letter "y" and sign ";"
  • you could add some description for your footer navigation like aria-label="social links navigation" because in real website it would be probably just a component and there would be another nav elements

Personally I would change span for p with your text "Subscribe and get notified. p is for paragraph and span is just like div but it has display: inline;

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord