Skip to content
Submitted over 3 years ago

Card Pricing Component using Stylus and Gulp

gulp, stylus
P
Jérôme Haas•320
@jeromehaas
A solution to the Pricing component with toggle challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

Are there any suggestions for improving the way I have written the BEM?

Code

Please log in to post a comment

Log in

Community feedback

  • Fraser Watt•1,790
    @fraserwat

    Hey Jerome, this is looking nice!!

    Few suggestions:

    • Check out the font on the spec / readme, I think you're using a different one to the design
    • Take a look at the <span> documentation https://developer.mozilla.org/en-US/docs/Web/HTML/Element/span. Generally you use this for emphasising text (e.g. making a single word in a <p>tag<p> a different colour), or applying a different style to specific headers/paragraphs. You probably want to replace most of your span tags with a different html element.

    BEM stuff all seems to be in order, and your toggle is really smooth.

    Keep up the good work, its looking great!!

    Fraser

    Marked as helpful
  • P
    Jérôme Haas•320
    @jeromehaas

    Thank you so much for the feedback, Fraser!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord