Card-Component

Solution retrospective
really though i'm looking for a better solution some one point me there i will be grateful
Please log in to post a comment
Log in with GitHubCommunity feedback
- @correlucas
👾Hello HMADAMK, congratulations for your new solution!
I saw your solution and seems already great, two things you can do to improve, one is to make the container card responsive by replacing its
width
withmax-width
to allow the card contract while scaling, note that is currently fixed the width size. Other thing is to wrap the whole card contents withmain
instead of div.👋 I hope this helps you and happy coding!
Marked as helpful - @DavidMorgade
Hello Hmadamk, congrats on finishing the challenge! great work!
It seems that you had a bit of trouble getting the profile card centered, try using flex-box directly on your
container
after removing themargin
on yourcard class
like this :.container { display: flex; justify-content: center; align-items: center; min-height: 100vh; }
Great work with the images, maybe setting them as a CSS background-image could have landed a better result, but you still got it!
Hope my feedback helps you!
Marked as helpful
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord