@samuelpalaciosdev
Posted
Hi, Xhoni๐
Great job on this challenge. Your solution looks good and it scales pretty well. ๐
I only suggest some things ๐:
-
On mobile viewport the menu isn't centered. As I'm seeing on your project that's because you set a margin-left to the anchor links (
.hero > .navbar > .nav-links > li a
) , I'd delete the margin-left and addalign-items: center;
on theul
which in this case you selected as:.hero > .navbar > .nav-links
. -
Be careful with specificity. I mean, you have extra large selectors like the one I mentioned above, you could simplify that setting a class to those elements and just selecting the class. As an example, adding this class to the anchor link
<a class= nav__link>
, you could select it on CSS as.nav__link
, and it is easier to read than the other selector
I hope this would help you, have a nice day, keep coding!๐
@Xhoni43
Posted
@samuelpalaciosdev Thx mate i will do the best in my next project
@samuelpalaciosdev
Posted
@Xhoni43 You're already doing your best! Remember, learning to code is a non-linear process and forcing a strictly linear structure on it will slow your learning process. It is analogous to learning a language.