Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Challenge #1

Xhoniโ€ข 70

@Xhoni43

Desktop design screenshot for the Loopstudios landing page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


How i can be better in layout and animation ??

Community feedback

Samuel Palaciosโ€ข 615

@samuelpalaciosdev

Posted

Hi, Xhoni๐Ÿ‘‹

Great job on this challenge. Your solution looks good and it scales pretty well. ๐Ÿ‘

I only suggest some things ๐Ÿ˜‰:

  • On mobile viewport the menu isn't centered. As I'm seeing on your project that's because you set a margin-left to the anchor links (.hero > .navbar > .nav-links > li a) , I'd delete the margin-left and add align-items: center; on the ul which in this case you selected as: .hero > .navbar > .nav-links.

  • Be careful with specificity. I mean, you have extra large selectors like the one I mentioned above, you could simplify that setting a class to those elements and just selecting the class. As an example, adding this class to the anchor link <a class= nav__link>, you could select it on CSS as .nav__link, and it is easier to read than the other selector

I hope this would help you, have a nice day, keep coding!๐Ÿ’™

1

Xhoniโ€ข 70

@Xhoni43

Posted

@samuelpalaciosdev Thx mate i will do the best in my next project

0
Samuel Palaciosโ€ข 615

@samuelpalaciosdev

Posted

@Xhoni43 You're already doing your best! Remember, learning to code is a non-linear process and forcing a strictly linear structure on it will slow your learning process. It is analogous to learning a language.

0
Vinci Taylaranโ€ข 185

@vincitaylaran

Posted

Great looking solution, Xhoni! The only thing I would have to knit pick is that the hero isn't dimmed. Making it dim will make the white text on it pop out more and appear more readable.

.hero {
    background: linear-gradient(rgba(0,0,0,0.5), rgba(0,0,0,0.5)), url(../assets/image-hero.jpg) no-repeat center center/cover
}

Otherwise, this looks really good! Looking forward to your progress :)

1

Xhoniโ€ข 70

@Xhoni43

Posted

@vincitaylaran thanks i done this but for some reason i delete it volontary ahah , so thanks i proceed to change it

0
thibault.devโ€ข 85

@thibault-deverge

Posted

It's really good but some important dรฉtails missed out, like the heading who is bold (in solution not) or text-align ! But really nice !

1

Xhoniโ€ข 70

@Xhoni43

Posted

@thibault-deverge thanks I noticed it now I proceed to change it

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord