Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Challenge 4: 3-Column Card Component

@nnall

Desktop design screenshot for the 3-column preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


More good practice.. Looking for input!

Updated RE footer & <a>

Community feedback

Adriano 34,000

@AdrianoEscarabote

Posted

Hi Nicholas Nall, how are you?

I really liked the result of your project, but I have some tips that I think you will enjoy:

To improve the code structure, wrap this div:

<div class="attribution">
    Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>.
    Coded by <a href="#">Nick</a>.
</div>

with the semantic tag footer.

change the button tag to an a tag, taking into account that the button is Learn more, I imagine this is not a form, or something like that, this button would probably take us to another page, read more about! so I think the a tag is the best choice in this case!

The rest is great!

I hope it helps... 👍

Marked as helpful

1
Jeck 1,080

@j-tomajin

Posted

Hello!

tips for attribution,

  • you may wrapped it inside a footer element

  • for it to be stick at the bottom you can:

body {
   position: relative;
   min-height: 100vh;
}

footer {
   position: absolute;
   bottom: 0;
   left: 0;
   right: 0;
}

HAPPY CODING!

Marked as helpful

0

@nnall

Posted

@AsukalDePapa

Thank you!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord