Challenge done using SCSS

Solution retrospective
Hey Everyone; I have completed the Fylo Dark theme Landing Page Challenge.
It has been done using both CSS and SCSS
Check out my following article, where I have briefly explained the steps I have followed to complete this challenge.
Using CSS:- https://medium.com/ux-planet/challenge-012-fylo-dark-theme-landing-page-f93c8b66206d
Using SCSS:- https://medium.com/ux-planet/challenge-015-fylo-dark-theme-landing-page-edaf39ca80f8
Thank you for checking this out, and feel free to leave your feedback and thoughts!! Any feedback and tips are welcome.
Many Thanks! Nathasha 😊
Please log in to post a comment
Log in with GitHubCommunity feedback
- @vanzasetia
Hi, Nathasha! 👋
Nice articles! It is great that you have spent some time sharing your knowledge. I will add the article that is "Using CSS" for the next Frontend Mentor Bundle. Here is the current one: Frontend Mentor Bundle — Vanza Setia
There are two things that can be done better.
- All page content should live inside a landmark. The logo and the navigation links should be wrapped by
<header>
landmark. The other elements that are not inside the<header>
and the<footer>
, should be wrapped by<main>
landmark. - There should not be more than one
h1
on a page. Many<h1>
elements mean many titles which can confuse the users, especially the screen reader users. Dive deeper — How-to: Accessible heading structure - The A11Y Project
I hope this helps. Happy coding! 😄
- All page content should live inside a landmark. The logo and the navigation links should be wrapped by
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord