Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Christmassy four card feature (html, css, js)

@JasonIanMatthews

Desktop design screenshot for the Four card feature section coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I know it's not as per the original challenge exactly but I'm new to coding, keen to learn and wanted to experiment with some extra additions. The christmas additions are not my own creations but copied (& modified for my solution) from google searches and xmas codepens. Happy Holiday Season! (btw the screenshot it added is not correct...better to check view the finished solution using 'Preview site' button ;-) )

Community feedback

P
ApplePieGiraffe 30,565

@ApplePieGiraffe

Posted

Hey, Jason Matthews! 👋

I love your idea to add Christmas decorations to your solution (something I've been thinking about, too, actually 😆). Who said you can only put Christmas decorations on a Christmas tree? 🎄LOL!

I don't think you have to transition to a mobile-friendly layout right at 1440px since there's still room for the desktop layout of the page for a bit. The only other thing I might suggest is taking a look at your solution report and trying to clear up some of the errors that are there (but they might be from codepens you added, IDK).

Keep coding (and happy coding, too)! 😁

Oh, yes, and merry Christmas, already! 🎅

1

@JasonIanMatthews

Posted

Thanks for the speedy feedback. I was toying with the 1440px and kept thinking I should've gone smaller....next time!

And yes, I saw all those errors come up, took a look and didn't understand a word as they're all the copied/pasted codes (I wouldn't normally just copy/paste without understanding anything btw. Actually, I haven't even learned js yet (just html & css) but wanted to liven it up. I'll learn the js when I can master html, css & page layouts, responsiveness etc)

thanks again :-)

0

@SankThomas

Posted

@JasonIanMatthews May I offer some advice that works for me? Take not of the 'for me' part but if you think it can work for you as well you can try it.

Open up the errors page on a separate tab, and then open your text editor, place them side by side. Then look through the errors and find out where they're placed inside your code, and try to make the suggested changes, but before you do, google to find out why you need the changes like the aria-label attribute and so on and so forth.

You'll get to learn where to place attributes and why they're placed as they are, and you'll get better as you go. I still have some validation errors as well, but not as much as I used to 3 months ago when I started with Frontend Mentor. And also, try to understand what certain blocks of code do, it is immensely helpful...

But like I said, that's just me...

0
Web Frog 1,840

@MasterDev333

Posted

Great work so far. In my humble opinion, it would be great if you use CSS-Grid rather than CSS-flex in card-container. As you know, CSS-Grid is good for x,y positioning elements while CSS-Flex is only for x positioning. Anyway, it looks fun and awesome. Happy coding~

0

@JasonIanMatthews

Posted

@MasterDev333 Thanks for the advice and compliment. I'm just learning about css-grid just as your message appeared so I hope to see its advantages soon and maybe re-code with this instead. I think grid will solve a lot of flex issues I'm struggling with re page placements!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord