Clean, simple & responsive QR component (Vanilla)

Community feedback

• 

  Fluffy Kas•7,655

  @FluffyKas

  Posted over 3 years ago

  Hi there,

  It looks very close to the original, there are only some corrections to be made in your HTML. ^^

  1. You have no landmarks. Adding a main would do the trick. You either add it inside the body or you replace the card div with it, both should be fine solutions.

  2. There's no reason to use width: 100% on the elements you used it on. Remove them, everything will stay the same.

  3. There's only one heading on this page so that should be an <h1> instead of <h2>. If you think about this design as part of a bigger website, you could still hide a <h1> somewhere, that gets rid of the issue in the accessibility report.

  4. Your attribution could go in a footer.

  Apart from these, good job! ^^

  13

  Marked as helpful
• 

  Duyen Nguyen•950

  @Duyen-codes

  Posted over 3 years ago

  Great solution! I'm thinking of doing this challenge using React. I'm starting to learn React so I would like to start small. How have you been?

  05

  Marked as helpful