@pikapikamart
Posted
Hey, awesome work on this one. Desktop layout looks great and those animation is really nice. The site is responsive as well and mobile state looks great.
For the modal, a div
would be fine on this one. An addition as well is to use aria-live
element that will announce if the server is down like what you are showing so that when the user toggles the download-button, they will be informed right away, because the modal will only be visible right away for sighted users but not for other people who are visually impaired.
Some other suggestions would be:
- Remember that a website-logo is one of the meaningful images on a site so use proper
alt
for it. Use the website's name as the value likealt="clipboard"
. - Reduce usage of
section
element since they don't really give much information unless they are labelled byaria-labelledBy
attribute. Adiv
would be fine for this one. - For non interactive elements, you don't need to add like a
cursor: pointer
for them or an animation that seems like they are ought to be clicked, but in reality you can't really interact with them. - When using
img
tag, you don't need to add words that relates to "graphic" such as "logo" and others, sinceimg
is already an image so no need to describe it as one. Use only the company name on this as thealt
value.
FOOTER
- Same with the company logo, use a more proper
alt
value. - Those 5 links could be inside a
nav
since those are still your website's navigational links. - Also, you could wrap the 5 links inside
ul
since those are "list" of links:
nav
ul
li a * 5
- Those social-media links could be inside a
ul
element since those are "list" of links. - Each
a
tag that wraps the social-media icon should have eitheraria-label
attribute orsr-only
text inside it, defining where the link would take them. For example, you should usefacebook
as the value if the link would take the user to facebook.
Aside from those, great job again on this one.
Marked as helpful
@Yazdun
Posted
@pikamart Hello Raymart ! I jumped back to the challenge fixed all the issues you mentioned here, Also I was exactly looking for something like aria live but I didn't find it on my own, I added it to my alert and javascript and now I feel so much better about it π
Thank you for your great feedback it helped me so much.