@brasspetals
Posted
Hi, Cody. Congrats on submitting another solution. 🎉 Overall, good job on this one. I don’t see any glitches, and it responds great - even on large screens (1920+), which sometimes gets overlooked. 👍
A few suggestions:
.contentcould be changed to amainelement rather than adivfor improved semantics.- Speaking of semantics, the links ul in the footer could be wrapped in a
nav. - One last thing - I’m unsure why you used empty divs between sections to add space when you could just put margins on the sections themselves. 🤔
Marked as helpful
@CodyKelly
Posted
@brasspetals Thanks so much! Had a lot of fun building this one as it was nice to really dive into using SCSS and see what that had to offer.
Excellent suggestions all around. I need to print out a cheat sheet for semantic HTML cause I always forget there's probably a tag out there that's a better fit for what I'm doing.
As for the empty divs... yes.. that's a bit of an ugly spot in the code, I have to go back in there and change that! I treat these projects as constant works in progress and am constantly going back and tweaking things, so thanks so much for the suggestions.
@brasspetals
Posted
@CodyKelly Semantic HTML and accessibility in general are constant learning processes for me. Here's an article on how to section HTML that I have referred back to many, many times. Constant improvement is the name of the game. 👍
Glad my suggestions could be of help! Looking forward to your next solution. 😄
