@MelvinAguilar
Posted
Hello there π. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
- All the links inside the
footer__links
class should be contained within an unordered list<ul>
element, placed within a<nav>
, wrapping the entire list of links within a<nav>
element would convey the purpose of the links as a navigation menu, enhancing the semantic meaning of the code.
- The alt attribute of the logo should not be left empty. The logo plays a significant role in the overall visual identity of the website. Consider using "Clipboard" as the alternative text.
- As a personal suggestion, you could consider using an unordered list
<ul>
for the brand images, as well as for the three social media links inside thefooter__socials
class.
- Using a minified CSS file is a great approach for optimizing websites. However, it's also important to consider providing access to the original source code for others who may want to review or modify it in a simple and quick way, without the need to use the inspector or any other tool. You can upload it as an additional file in the repository without the need to link it to the HTML.
- The link in the footer with the text "Frontend Mentor" is missing the
rel="noopener noreferrer"
attribute. Adding this attribute is important for security reasons when using thetarget="_blank"
attribute.
- It seems that there is some direct text content within the
<div>
element with classattribution
:
ββ<div class="attribution">
βββ ββββ βChallenge by ...
ββ</div>
βββ ββββ βββ ββββ βββββ ββββ βWrap the text in a paragraph.
I hope you find it useful! π
Happy coding!