@vanzasetia
Posted
👋 Hi Anosha Ahmed!
🎉 Congratulations on finishing this challenge! 🙌 Your solution is responsive and pixel-perfect based on the design comparison! 👍Good job!
I have some feedback in this solution:
- Create a custom
:focus-visible
styling to any interactive elements (button
, links,input
,textarea
). This will make the users can navigate this website using keyboard (Tab
) easily. - In this case, there's no
header
, so you can put everything inside themain
element. Also, theheader
should not contain hero section, which in this case thesection
with the classheader__section
. Also, all the elements should be inside thesection
tag, since it is the part of that section.
<section class="header__section">
<div class="header__logo">
<img src="images/logo.svg" alt="#">
</div>
<h1 class="heading--1">A history of everything you copy</h1>
<p class="desc">
Clipboard allows you to track and organize everything you
copy. Instantly access your clipboard on all your devices.
</p>
<div class="header__btns btns">
<a href="#" class="btn--cyan">Download for iOS</a>
<a href="#" class="btn--blue">Download for Mac</a>
</div
</section>
- I would recommend every section is wrapped by
section
tag for better semantic markup. Eachsection
should contain a heading tag (h2
).
<section>
<h2 class="heading--2">Keep track of your snippets</h2>
<p class="desc desc--snippets">
Clipboard instantly stores any item you copy in the cloud,
meaning you can access your snippets immediately on all your
devices. Our Mac and iOS apps will help you organize everything.
</p>
... some code
<div>
<h3 class="heading--3">Complete History</h3>
<p class="desc">Retrieve any snippets from the first moment you started using the app.</p>
</div>
</div>
</div>
</section>
- You can make it(the below code & another part of your code) as an unordered list and wrap each item with
li
. Also, there's no reason to make the textQuick Search
,iCloud Sync
, andComplete History
as a heading. The below content is too small. You can think of the heading tag as a title on a document file.
<div class="snippets-container__text">
<div>
<h3 class="heading--3">Quick Search</h3>
<p class="desc">Easily search your snippets by content, category, web address, application, and more.</p>
</div>
<div>
<h3 class="heading--3">iCloud Sync</h3>
<p class="desc">Instantly saves and syncs snippets across all your devices.</p>
</div>
<div>
<h3 class="heading--3">Complete History</h3>
<p class="desc">Retrieve any snippets from the first moment you started using the app.</p>
</div>
</div>
- The logo image is an important image since it identifies the users what website they are currently at. so you can use the company name which is Clipboard as the alternative text.
- The alternative text for any image should not contain the word, image, logo, etc, since the screen reader will pronounce it as an image and the user will know that it is a logo (the same as we see the image).
- Don't change the
html
(root) font size. It can serious issue. Read what an accessibility expert has said about it. Since you are using Sass, you can create arem()
function that can automatically convert thepx
torem
for you.
@function rem($value) {
@return ($value / 16) * 1rem
}
- How it works:
/* In Sass file (.scss) */
body {
font-size: rem(16);
}
/* In CSS file */
body {
font-size: 1rem;
}
That's it! Hopefully, this is helpful!
Marked as helpful
@anoshaahmed
Posted
@vanzasetia Wow, thank you for teaching me new things, Vanza!!!!!!!!! Some of your points are going straight into my notes. I appreciate you so much!
@vanzasetia
Posted
@anoshaahmed You're welcome! Glad to know that it is helpful!
@vanzasetia
Posted
@anoshaahmed I have one suggestion that I forget to mention earlier, you don't need to push the node_modules
folder to the GitHub repo.
I would recommend creating and pushing the .gitignore
file so that if you or somebody else want to work with it, they don't need to worry about unwanted file like (.DS_Store
) or folder getting pushed to the GitHub repo.
Marked as helpful
@anoshaahmed
Posted
@vanzasetia I ACTUALLY NEEDED TO KNOW THAT LOL. i googled it but i still didn't know for sure so thank u for letting me know.
One question though: Would my Git Page keep working?
@vanzasetia
Posted
@anoshaahmed Yes, the GitHub page is fine without the node_modules
folder.
Marked as helpful