Hello, Mojtaba! 👋
Good job on finishing another challenge! What I can suggest you is:
- Since your
.header__logoimage is decorative youralttext should be provided empty (alt="") so that they can be ignored by assistive technologies, such as screen readers. - Your
.header containerbackground doesn't stretch full width on higher resolutions. Use Responsive Design Mode to see how your site behave on different resolutions. - Wrap
.footer__social-iconsinto some anchor tags.
Good luck with that, have fun coding! 💪
@tediko Answering the question, I think your BEM looks good. It is clean, you're using modifiers in good way and also using reusable elements like .card. Good job. Since you're using Sass, take a minute and read about 7-1 pattern to keep your file management orginazed.
@MojtabaMosavi
Posted
@tediko Thanks, I tought about setting 'aria-hidden=true' on it but forgot. I checked out your solution, it looks really clean and precise (great job), what tool do you use for measurement ?
@MojtabaMosavi There's a chrome extension called pixel perfect where you put image and you can set opacity on that image, so you can set your elements to fit with design. Other way if u can afford is to use premium and have acces to design files.
@MojtabaMosavi
Posted
@tediko Thanks, I try to use in the next project.
