@shashilo
Posted
Really good effort on this, but I can see many issues with this implementation.
- You are over complicating the use of CSS Grid. There are way too many rows and columns. Instead, only create a column or row for grouped items.
- Semantically, you are using too many
divsand your headings are all<h4>. Headings should be incremental starting with<h1> - Taking a closer look at the details of the design. The font-weights, font-size, text-align, image size, button arrow size, etc. are different from the design. This is being picky, but you'll realize that clients and designers are very pixel picky.
- Your mobile screen is good, but it also is missing some details. The slide action doesn't work either on mobile.
@gulayyolcu
Posted
@shashilo i tried to do it by using only grid, i understood grid wrong. I supposed, grid and flexbox using together is right way. If i don't use divs, i can't place them..i should remove which i never used.I'm a newbie:) you have one solution and 345 scores, where is your other solutions?:)
@shashilo
Posted
@gulayyolcu I can tell you're learning. These comments are to help you improve and gain the knowledge of being not only better at design implementation, but also thinking about the maintenance of an application.
I do not have other solutions yet because I've got a busy life. I wanted to accomplish one for now and help others by critiquing their work. You can see some of my work if you look at my Twitter feed.
