Coding Bootcamp Testimonials Slider (HTML | CSS | JS Vanilla)

Community feedback

• 

  P

  Miran Legin•740

  @miranlegin

  Posted over 2 years ago

  Hi Cheosphere,

  congratulations on completing this challenge!

  I'm impressed how you did this challenge because in my view there are probably 20% or more code which is definitely not needed here and i think you made yourself life much harder with this one. There are lots of hard-coded values especially on the height of elements and with things like that life can be so much harder when you need to maintain all that stuff.

  What probably bothers me the most is the sizing of the actual buttons for the slider. They are really hard to click because they are to small, you can read some info on setting size on buttons.

  Other that that it would be better to use button element instead of a a tag here also because a have different purpose. It is used primarily for links.

  Also when i click on the slider buttons there is an instant scrollbar to the right side which is causing content to jump from right to left and back an is easily avoidable with probably smaller value for scale.

  Blockquote tag and an H2 could be switched with flex-direction: column is you wanted to switch their places without using negative order on the blockquote itself. Also i'm not an expert it semantics but i don't think that blockquote is used properly here.

  Key takeaway from this is to try and make yourself life easier without fighting the layout so much. You've used all the techniques for positioning so you already have some knowledge but using it rightly takes some time and practice.

  Keep coding!

  Cheers, Miran

  23

  Marked as helpful