Hi Christopher,
Lovely, lovely job here! I'm also pretty new to React and have been learning it for a few months so it's nice to find a fellow student.
I noticed a couple of problems with the final modal 1) Keyboard focus doesn't move there and 2) The body remains scrollable.
I've been lucky to be an early test on Josh Comeau's Joy of React course and just yesterday did the modal lesson. It can be really hectic, but there's a couple of packages that can basically solve this for you:
- react-focus-lock - moves and locks focus to the modal
- react-remove-scroll - removes scroll from all other elememts
I've not tried them on a project but they seem pretty simple to implement and it might be worth giving them a try?
Cheers Dave
Marked as helpful
@christopher-adolphe
Posted
Hi @dwhenson š
That's a really good catch. I disabled mouse scrolling when the modal is opened but I completed missed that the modal wasn't accessible via the keyboard. I'll definitely have look at those packages and release a fix for that issue.
I'll also have a look at this Joy of React
course when it will be available. It sounds interesting as per the description on the website. What is your feedback about it so far ? Would you recommend it ?
Thanks for this helpful review.
Best regards.
@christopher-adolphe I think Josh will open it up in January for early purchases at a discount (but it won't be finished). His CSS course is 50% off today - grab it if you can!
His courses aren't cheap. But they are really, really good. I learnt a lot on the CSS one, and I already knew quite a bit of CSS (don't worry if you're not a JavaScript developer, I certainly am not!)
For React, I didn't know any React at all before starting, so it's harder for me to comment. But I suspect it'll also be really good. I know from interacting with Josh he is really taking care to make it great.
I have only learnt from that course and have a long way today, but did a couple of React challenges from here the other week, and felt pretty good about that!
If you can afford them, I think both are a really solid investment.
Cheers Dave
@christopher-adolphe
Posted
@dwhenson The quality of Josh's blog content is great so I can only imagine that same goes for the courses he creates. The price is definitely something that plays against me. Even with purchasing power parity applied, it's not easy to afford for me.
I'll check the course when it's out and take a decision from there.
Thanks again.
Best regards.