Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 3 years ago

Coming soon page using flexbox and built in validation

maia•300
@maiaflow
A solution to the Base Apparel coming soon page challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I know my JS isn't quite right, obviously because it isn't working and is always showing the error message. But I'm wondering what the proper way would be. Even if my code did work, I believe it would only run once, when I need it to run and check for an invalid pseudoclass every time something new is typed in the box.

I was also wondering if there was any problem with how I relied on built in browser validation rather than using javascript or a library.

Thanks!

Code
Loading...

Please log in to post a comment

Log in with GitHub

Community feedback

  • Eric Salvi•1,350
    @ericsalvi
    Posted almost 3 years ago

    Hey @maiaflow,

    Great job from a rendered finished product. You have come a long way in the few that you have submitted. This one is very responsive. The only thing I would keep on remembering to do is check out the report that gets generated on your submission. https://www.frontendmentor.io/solutions/coming-soon-page-using-flexbox-and-built-in-validation-OcWjIS-An6/report You have a few accessibility ones that can easily be fixed.

    Now one it comes to the JS.... there are many different ways to approach this and it really comes down to what works for you. The way I created mine is what made sense in my head but the way you attacked it is something I would not have thought of.

    I did find out about pattern parameters on certain inputs that take Regex so maybe doing your way with patterns might help if you decide to finish this one up.

    Check out: https://www.youtube.com/watch?v=g-Y31Iswr2M

    Cannot wait to see your next submission.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub