Looking to hire developers?
Hey everyone! I tried a lot of new things with this project. This was my first time using grid for the desktop layout, and I also added the ability to submit the email by both clicking on the button and pressing the Enter key. I also decided to add a success message if the email is validated correctly, because it felt a bit barebones without one.
I know the layout for medium screens is a bit weird because I wasn't sure how to position things with such little content, and on larger screens there's quite a bit of space under the logo, but since my main focus was on practicing JS, I'm pretty proud of how this turned out. As usual, I'm open to any feedback, as well.
@Da-vi-de
Posted
Hi Lesley, it looks very good, imo it's perfect!
I like how you work: code indentation, comments.
I wouldn't rely on px unit especially for media queries, i saw you use
rem, it's great for everything else not just for font-size.
Happy coding :-)
Marked as helpful
@LesleyWesley
Posted
@Da-vi-de Thank you so much! I'll try not to rely so much on px in my next project :)
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord
