Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Completed using HTML, CSS, JavaScript

James 510

@Auddity

Desktop design screenshot for the FAQ accordion card coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


This is a re-upload.

Cleaner HTML, Answer box smooth transition

Community feedback

Shahin NJ 1,190

@SJ-Nosrat

Posted

Hi James, Really well done on this challenge! My suggestions are with regards to your HTML tags used, as follows:

  1. The <div class="container"> can be a <main class="container"> tag.
  2. The <div class="card"> can be an <article class="card"> tag.
  3. The <div class="box"> can be a <figure class="box"> tag.
  4. The <h1>FAQ</h1> can also be <title>FAQ</title> tag wrapped within a <header> tag; as this will provide a landmark; you can learn more about landmarks in the report generated by Frontend Mentor.

The above is to orient you with using more meaningful tags to both the browser and the end-user using screen readers in order to better assist in accessibility.

You can learn more about Semantic HTML here.

Before using <div> I always ask myself what does this content in my page mean? If for example it's an <img> tag, then I'll wrap it in a <figure>; if I'd want to wrap the image; also provides a good landmark.

Hope the above helps!

Best of luck with your coding journey!

Marked as helpful

3

James 510

@Auddity

Posted

@shahin1987 Thanks for the feedback

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord