Component using HTML/CSS and Figma

Community feedback

• 

  Thomas Hertog•865

  @thomashertog

  Posted almost 2 years ago

  Your solution is looking good visually, there are some improvements that can be made though.

  HTML

  • I feel you're using the heading levels wrong. If you'd write them out in a table of contents like this 1. <h1> / 1.1. <h2> / 1.1.1. <h3> it doesn't really make sense
  • The <button> is missing a type
  • The content in the Why us section feels like a list of links to me, so I'm wondering why you marked it up as a <p> with <br>

  CSS

  • no need to make the button fixed size in both width and height using px
  • the code within the media query for your body is not needed in a media query, it should be the default (and making sure that the mobile view is vertically centered as well)
  • a lot of the properties don't affect anything in particular, so you could easily save a few lines of code here and there (making it easier to change afterwards when necessary)

  02

  Marked as helpful