Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

.container { width: 20%; height: 65%; border-radius: 0.8re

#accessibility#animation#astro#bulma#backbone

@FlashyKaizen

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


it's because of the padding and margin of each div. img, in my local page the image is showing. but in the github page it wont. how can we master inline the two divs or make them looks like a list.

Community feedback

Adriano 34,020

@AdrianoEscarabote

Posted

Hi Code Kaizen, how are you?

Welcome to the front-end mentor community!

I really liked the result of your project, but I have some tips that I think you will enjoy:

  • every Html document must contain the main tag, so we can identify the main content, to fix this, wrap all the content with the main tag. HTML5 landmark elements are used to improve navigation experience on your site for users of assistive technology.
  • To align some content in the center of the screen, always prefer to use display: flex; it will make the layout more responsive!

Example:

body {
    margin: 0;
    padding: 0;
    display: flex;
    align-items: center;
    justify-content: center;
    min-height: 100vh;
}

The rest is great!

I hope it helps... 👍

1

@thejackshelton

Posted

Hey, my man! You did a great job!

The image isn't showing up because you need to add a period before your slash (/) in the src file.

Try adding it like this: <img src="./image-qr-code.png" alt="">

side note: try adding alt text to each of your images, just describe what the picture is for. (It's good for SEO & accessibility)

Another thing is flex is affected by the parent container. In this case, you have a class called a container, and another div called content.

If you wanted to center the content in the middle, you would need to add the following:

.content { display: flex; justify-content: center; align-items: center; }

That way, you can remove your margin-top that is in your container class.

If this helped, I'd appreciate it if you hit the "Marked As Helpful" button. If you need any more help hop in the slack community :)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord