Skip to content
Submitted 10 months ago

create QR code component

ahmadyovan•10
@ahmadyovan
A solution to the QR code component challenge
Preview (opens in new tab)Code (opens in new tab)
Code

Please log in to post a comment

Log in

Community feedback

  • P
    Øystein Håberg•13,280
    @Islandstone89

    HTML:

    • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Change <div class="main"> into a <main>.

    • The alt text must also say where it leads(the frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."

    • I would change the heading to a <h2> - a page should only have one <h1>, reserved for the main heading. As this is a card heading, it would likely not be the main heading on a page with several components.

    • .attribution should be a <footer>, and you should use <p> for the text inside. The <footer> must be outside of the <main> element.

    CSS:

    • It is best practice to write CSS in a separate file, often called style.css. Create one in the same folder as the index.html, and link to it in the <head>: <link rel="stylesheet" href="style.css">.

    • Including a CSS Reset at the top is good practice.

    • I recommend adding 1rem of padding on the body, to ensure the card doesn't touch the edges on small screens.

    • Move all the properties on .main to body. Change height to min-height—this way, the content will not get cut off if it grows beneath the viewport. Remove width, as block elements like body are 100% wide by default.

    • Remove the width in px on the card. We rarely want to give a component a fixed size, as we want it to grow and shrink according to the screen size.

    • We do want to limit the width of the card, so it doesn't get too wide on larger screens. To solve this issue, give the card a max-width of around 20rem.

    • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

    • Paragraphs have a default value of font-weight: 400, so there is no need to declare it.

    • Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.

    • On the image, add display: block and change width to max-width: 100% - the max-width prevents it from overflowing its container. Without this, an image would overflow if its intrinsic size is wider than the container. max-width: 100% makes the image shrink to fit inside its container.

    • Instead of writing .card p, it's recommended to give elements a class and use that as a selector, as this keeps specificity low and flat.

    • As the design doesn't change, there is no need for any media queries. When you do need them, they should be in rem or em, not px.

  • AlisCodeSpace•110
    @AlisCodeSpace

    Both Paragraphs need text-align: center. Bold paragraph should have a font-size of 22px. Adjust the width of the paragraphs to 256px.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord