Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Create QR component with html, css + flex box

#styled-components#itcss

@imbranatoInformatico

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@MelvinAguilar

Posted

Hi @imbranatoInformatico 👋, good job completing this challenge, and welcome to the Frontend Mentor Community! 🎉

In addition to the previous comments, I have some suggestions you might consider to improve your code:

  • The color of the last paragraph element is unreadable because it is too light compared to its background. For example, change the color to hsl(220deg, 15%, 55%).
  • In this challenge, you should not use the background property to set the image because this image has semantic meaning. Use the CSS background property if the image is not part of the content.
  • For specificity reasons you should work better with classes since they are reusable, and you can leave the ID when you work with Javascript.
  • Instead of using pixels in font size, use relative units of measure like rem or em. The font size in absolute length units (px) does not allow users with limited vision to change the text size in some browsers. Reference.
  • Use an h1 tag for your solution. The <h1> element is the main heading on a webpage, also, there should only be one <h1> tag per page.
<h1>Improve your front-end skills by building projects</h1>

I hope those tips will help you! 👍

Good job, and happy coding! 😁

Marked as helpful

1
Adeola Ganiu 1,320

@Deolabest

Posted

Hey @imbranatoInformatico, Congratulations on completing this challenge!

Here is my feedback:

  • It's not a good practice to use px to set font-size. Instead use rem units, they are great since they adapt better to the font-size the user will set in the browser settings. You can convert from px to rem here: https://pixelsconverter.com/px-to-rem.

  • Use <main> instead of a simple <div> to improve the semantics and accessibility on the page. Remember that every page should have a <main> block and that <div> doesn't have any semantic meaning.

Keep doing a good job!

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord