Skip to content
Submitted about 4 years ago

Created Calculator using scss and typescript

Dinesh•1,115
@Dinesh1042
A solution to the Calculator app challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

```Feedback are requested````😍

Code

Please log in to post a comment

Log in with GitHub

Community feedback

  • Matt Studdert•13,611
    @mattstuddert

    Really nice submission, Dinesh! @palgramming has made some excellent points. I'd also recommend refining how it works with keyboard-only navigation. At the moment, if you're using your keyboard, the numbers overwrite each other.

    You've done an amazing job of matching the design, though, and the theme switching transition is beautiful! 😍

    Keep up the amazing work!

  • P
    Patrick•14,265
    @palgramming

    Congrats being the first person I have seen to upload this project

    I really like your animation transition when the color modes are selected

    The buttons are missing their hover states the design files have specific colors but you could just change opacity or something to all of them

    also some of the calculator logic need a little work. You could make it work with negative numbers like -3 * 4 = -12

    I do like how you did your number/total display also that is really nice

    this is the kind of challenge you can refine and refine and refine but really nice job so far

  • Bantu Ralana•15
    @banturalana

    Great stuff

  • Misael Lopes•95
    @misaellopes01

    Amaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaazing!

  • ApplePieGiraffe•30,525
    @ApplePieGiraffe

    Greetings, Dinesh! 👋

    Fantastic work on this challenge! 🙌 This challenge has only just come out, but you've done a very nice job on it! 😀 Overall, the calculator seems to work pretty well and those theme-transitions are simply awesome! 🤩

    The only very minor suggestion from me would be to add some space around the top and bottom of the calculator (using margin/padding) so that it isn't right up against the edges of the viewport at small screen heights. 😉

    Of course—keep coding (and happy coding, too)! 😁

  • tediko•6,700
    @tediko

    Hello, Dinesh! 👋

    Well done on this challenge! Kudos for theme animations, it looks nice! I will definitely look at this soultion when I do it on my own!

    Keep up the good work! 💪

  • Fidel Lim•2,775
    @fidellim

    Wow! Great implementation, I like it!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord